fix(collector/pcidevice): Add nil checks to prevent panic #3421
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiger1218 <tiger1218@foxmail.com>
Tiger1218
force-pushed
the
fix/pcidevice-panic
branch
from
f19e494 to
11bd515
Compare
|
I have also encountered this panic error. In my case, I've got the following stack trace: The issue occurs in my environment where This PR's fix addresses exactly what I'm experiencing. |
SuperQ
reviewed
Oct 22, 2025
| var maxLinkWidth, currentLinkWidth float64 | ||
|
|
||
| if device.MaxLinkSpeed != nil { | ||
| maxLinkSpeedTS = float64(int64(*device.MaxLinkSpeed * 1e9)) |
There was a problem hiding this comment.
This will emit a 0 for metrics we don't know the value for.
I think we should do something like this:
Suggested change
| maxLinkSpeedTS = float64(int64(*device.MaxLinkSpeed * 1e9)) | |
| ch <- c.descs[0].mustNewConstMetric(maxLinkSpeedTS, device.Location.Strings()...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pcidevice collector panics with a "nil pointer dereference" error
on some systems. This occurs when a PCI device lacks certain attributes
in sysfs, such as 'current_link_speed' or 'current_link_width'.
The collector's Update method attempted to dereference these pointers
without verifying if they were nil, leading to a crash.
This commit introduces checks to verify that the link speed and width
pointers are not nil before they are dereferenced. If an attribute is
missing for a device, its corresponding metric will now be reported as 0,
making the collector more robust and preventing node_exporter from
crashing.